Re: non-exclusive backup cleanup is mildly broken - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: non-exclusive backup cleanup is mildly broken
Date
Msg-id 20191219071308.GA45286@paquier.xyz
Whole thread Raw
In response to Re: non-exclusive backup cleanup is mildly broken  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Wed, Dec 18, 2019 at 07:43:43AM -0500, Robert Haas wrote:
> On Tue, Dec 17, 2019 at 11:36 PM Fujii Masao <masao.fujii@gmail.com> wrote:
>> If pg_abort_backup callback function can be called safely even when
>> the backup is not in progress, we can just use the global variable like
>> pg_abort_backup_registered to register the callback function only
>> on first call. In this way, cancel_before_shmem_exit() doesn't need to
>> search the array to get rid of the function.
>
> Right. That's how the proposed patch works.

Well, it seems like I am a poor lonesome cowboy on this one then.
And what you are proposing does not break things either as far as I
checked, so I'll just go hide in a corner :)
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: logical decoding : exceeded maxAllocatedDescs for .spill files
Next
From: Peter Eisentraut
Date:
Subject: Re: automating pg_config.h.win32 maintenance