Re: pgsql: Refactor attribute mappings used in logical tupleconversion - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Refactor attribute mappings used in logical tupleconversion
Date
Msg-id 20191218081514.GA325369@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Refactor attribute mappings used in logical tupleconversion  (er <er@xs4all.nl>)
List pgsql-committers
On Wed, Dec 18, 2019 at 08:43:47AM +0100, er wrote:
> gcc (9.2.0) mutters this:
>
> tupconvert.c: In function ‘execute_attr_map_tuple’:
> tupconvert.c:146:8: warning: unused variable ‘outnatts’ [-Wunused-variable]
>   146 |  int   outnatts = map->outdesc->natts;
>       |        ^~~~~~~~
>
> (Otherwise compiles & runs fine.)

This one could use a PG_USED_FOR_ASSERTS_ONLY to work properly, but it
is more simple to just remove the variable.  Thanks for the report,
Erik.
--
Michael

Attachment

pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Add .editorconfig
Next
From: Thomas Munro
Date:
Subject: Re: pgsql: Partially deduplicate interrupt handling for background processe