Re: pgbench - add \aset to store results of a combined query - Mailing list pgsql-hackers

On Thu, Aug 15, 2019 at 06:30:13PM +0000, Ibrar Ahmed wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world:  tested, passed
> Implements feature:       tested, passed
> Spec compliant:           tested, passed
> Documentation:            not tested
>
> The patch passed my review, I have not reviewed the documentation changes.
>
> The new status of this patch is: Ready for Committer

@@ -524,6 +526,7 @@ typedef struct Command
    int         argc;
    char       *argv[MAX_ARGS];
    char       *varprefix;
+   bool        aset;

It seems to me that there is no point to have the variable aset in
Command because this structure includes already MetaCommand, so the
information is duplicated.  And I would suggest to change
readCommandResponse() to use a MetaCommand in argument.  Perhaps I am
missing something?
--
Michael