On Fri, Nov 15, 2019 at 10:34:55AM +0900, Michael Paquier wrote:
> It seems to me that if the plan is to have one option structure for
> each index AM, which has actually the advantage to reduce the bloat of
> each relcache entry currently relying on StdRdOptions, then we could
> have those extra assertion checks in the same patch, because the new
> macros are introduced.
I have looked at this patch, and did not like much having the
calculations of the page free space around, so I have moved that into
each AM's dedicated header.
> There is rd_rel->relam. You can for example refer to pgstatindex.c
> which has AM-related checks to make sure that the correct index AM is
> being used.
We can do something similar for GIN and BRIN on top of the rest, so
updated the patch with that. Nikolay, I would be fine to commit this
patch as-is. Thanks for your patience on this stuff.
--
Michael
