Re: PHJ file leak. - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject Re: PHJ file leak.
Date
Msg-id 20191112.121958.521015722194151380.horikyota.ntt@gmail.com
Whole thread Raw
In response to Re: PHJ file leak.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: PHJ file leak.
List pgsql-hackers
At Mon, 11 Nov 2019 17:24:45 -0500, Tom Lane <tgl@sss.pgh.pa.us> wrote in 
> Although the patch seems unobjectionable as far as it goes, I'd like
> to understand why we didn't see the need for it long since.  Is there
> another call to ExecParallelHashCloseBatchAccessors somewhere, and
> if so, is that one wrongly placed?

The previous patch would be wrong. The root cause is a open batch so
the right thing to be done at scan end is
ExecHashTableDeatchBatch. And the real issue here seems to be in
ExecutePlan, not in PHJ.

regards

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



pgsql-hackers by date:

Previous
From: Chapman Flack
Date:
Subject: Re: documentation inconsistent re: alignment
Next
From: Michael Paquier
Date:
Subject: Re: [bug fix] Produce a crash dump before main() on Windows