On 2019-Oct-19, Etsuro Fujita wrote:
> On Fri, Oct 18, 2019 at 6:56 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> > Yeah, agreed. Instead of "the null comes from" I would use "the
> > partition that stores nulls".
>
> I think your wording is better than mine. Thank you for reviewing!
Thanks for getting this done.
> > While reviewing your patch I noticed a few places where we use an odd
> > pattern in switches, which can be simplified as shown here.
>
> case PARTITION_STRATEGY_LIST:
> - num_indexes = bound->ndatums;
> + return bound->ndatums;
> break;
>
> Why not remove the break statement?
You're right, I should have done that. However, I backed out of doing
this change after all; it seems a pretty minor stylistic adjustment of
little value.
Thanks for reviewing all the same,
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
