Re: v12 pg_basebackup fails against older servers (take two) - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: v12 pg_basebackup fails against older servers (take two)
Date
Msg-id 20191022133550.GA2038@paquier.xyz
Whole thread Raw
In response to Re: v12 pg_basebackup fails against older servers (take two)  (Stephen Frost <sfrost@snowman.net>)
Responses Re: v12 pg_basebackup fails against older servers (take two)
List pgsql-hackers
On Tue, Oct 22, 2019 at 09:06:03AM -0400, Stephen Frost wrote:
> Here's just a quick rough-up of a patch (it compiles, I haven't tried it
> out more than that) that adds in a check to skip gssencmode on older
> versions.  If it seems like a reasonable approach then I can test it out
> and deal with back-patching it and such.
>
> Thoughts?

Here is a thought.  We could tackle the problem at its source and
track in internalPQconninfoOption the minimum version supported by a
parameter.  This way, we could make sure that libpq routines similar
to PQconninfo() never return an option which is not compatible with a
a live connection, and we won't forget that if the problem shows up
again because creating a new parameter would require to add a new
version number.  There is an advantage here: internalPQconninfoOption
is an internal structure, so this should be back-patchable.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: v12 pg_basebackup fails against older servers (take two)
Next
From: Stephen Frost
Date:
Subject: Re: v12 pg_basebackup fails against older servers (take two)