Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Fix parsing of integer values for connection parametersin libpq - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Fix parsing of integer values for connection parametersin libpq
Date
Msg-id 20191022100553.GA3908@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Fix parsing of integer values for connection parameters inlibpq  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: pgsql: Fix parsing of integer values for connection parametersin libpq  (Michael Paquier <michael@paquier.xyz>)
List pgsql-committers
Tree view 
On Tue, Oct 22, 2019 at 10:05:45AM +0200, Peter Eisentraut wrote:
> You probably want something like
>
>     if (end && *end != ...)

Yes, it looks like a brain fade here.  Conversion failures are tracked
before that, so strtol() would not return NULL for endptr.  The first
part could just be removed as per the attached.
--
Michael
Attachment

pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Make command order in test more sensible
Next
From: Michael Paquier
Date:
Subject: pgsql: Clean up properly error_context_stack in autovacuum worker on ex