Re: dropping column prevented due to inherited index - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: dropping column prevented due to inherited index
Date
Msg-id 20191011213947.GA10170@alvherre.pgsql
Whole thread Raw
In response to Re: dropping column prevented due to inherited index  (Michael Paquier <michael@paquier.xyz>)
Responses Re: dropping column prevented due to inherited index
List pgsql-hackers
On 2019-Oct-11, Michael Paquier wrote:

> +    if (!recursing)
> +    {
> +        /*
> +         * The resursing lookup for inherited child relations is done.  All
> +         * the child relations have been scanned and the object addresses of
> +         * all the columns to-be-dropped are registered in addrs, so drop.
> +         */
> +        performMultipleDeletions(addrs, behavior, 0);
> +        free_object_addresses(addrs);
> +    }

Typo "resursing".  This comment seems a bit too long to me.  Maybe
"Recursion having ended, drop everything that was collected." suffices.
(Fits in one line.)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: stress test for parallel workers
Next
From: Andres Freund
Date:
Subject: Re: let's make the list of reportable GUCs configurable (was Re: Add%r substitution for psql prompts to show recovery status)