Re: format of pg_upgrade loadable_libraries warning - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: format of pg_upgrade loadable_libraries warning
Date
Msg-id 20191009021729.GB3191@momjian.us
Whole thread Raw
In response to Re: format of pg_upgrade loadable_libraries warning  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On Mon, Oct  7, 2019 at 01:47:57PM -0400, Bruce Momjian wrote:
> On Fri, Oct  4, 2019 at 11:55:21PM -0400, Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > On Fri, Oct  4, 2019 at 05:40:08PM -0500, Justin Pryzby wrote:
> > >> I would argue to include in 12.1, since 12 is what most everyone will use for
> > >> upgrades, and patch for .1 will help people upgrading for 11 of the next 12
> > >> months.  (But, your patch is more general than mine).
> > 
> > > No, there might be tools that depend on the existing format, and this is
> > > the first report of confusion I have read.
> > 
> > Translations will also lag behind any such change.  Speaking of which,
> > it might be a good idea to include some translator: annotations to
> > help translators understand what context these fragmentary phrases
> > are used in.  I'd actually say that my biggest concern with these
> > messages is whether they can translate into something sane.
> 
> Uh, I looked at the pg_ugprade code and the error message is:
> 
>         pg_fatal("Your installation contains \"contrib/isn\" functions which rely on the\n"
>                  "bigint data type.  Your old and new clusters pass bigint values\n"
>                  "differently so this cluster cannot currently be upgraded.  You can\n"
>                  "manually upgrade databases that use \"contrib/isn\" facilities and remove\n"
>                  "\"contrib/isn\" from the old cluster and restart the upgrade.  A list of\n"
>                  "the problem functions is in the file:\n"
>                  "    %s\n\n", output_path);
> 
> and the "in database" (which I have changed to capitalized "In database"
> in the attached patch), looks like:
> 
>                fprintf(script, "In database: %s\n", active_db->db_name);
> 
> meaning it _isn't_ an output error message, but rather something that
> appears in an error file.  I don't think either of these are translated.
> Is that wrong?

Patch applied to head.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: [HACKERS] Block level parallel vacuum
Next
From: "Jordan Deitch"
Date:
Subject: WIP: raise error when submitting invalid ALTER SYSTEM command