Re: pgsql: Fix progress reporting of CLUSTER / VACUUM FULL - Mailing list pgsql-committers

From Alvaro Herrera
Subject Re: pgsql: Fix progress reporting of CLUSTER / VACUUM FULL
Date
Msg-id 20190913185241.GA4516@alvherre.pgsql
Whole thread Raw
In response to Re: pgsql: Fix progress reporting of CLUSTER / VACUUM FULL  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On 2019-Sep-13, Tom Lane wrote:

> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > Fix progress reporting of CLUSTER / VACUUM FULL
> 
> Not a new problem of this patch, exactly, but:
>  
>  /* Reindex options */
>  #define REINDEXOPT_VERBOSE 1 << 0  /* print progress info */
> +#define REINDEXOPT_REPORT_PROGRESS 1 << 1  /* report pgstat progress */
> 
> Surely these macro definitions are incredibly dangerous due to their
> lack of parentheses.

Ugh, I knew there was something odd here in the back of my mind but I
was unable to see what it was :-(  I'll fix those definitions.

Thanks for looking,

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Fix progress reporting of CLUSTER / VACUUM FULL
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Fix under-parenthesized macro definitions