Re: psql - improve test coverage from 41% to 88% - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: psql - improve test coverage from 41% to 88%
Date
Msg-id 20190912013724.GB18505@paquier.xyz
Whole thread Raw
In response to Re: psql - improve test coverage from 41% to 88%  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: psql - improve test coverage from 41% to 88%
List pgsql-hackers
On Wed, Sep 11, 2019 at 10:52:01PM +0200, Fabien COELHO wrote:
> AFAICR this is because the coverage was not the same:-) Some backslash
> commands just skip silently to the end of the line, so that intermediate
> \commands on the same line are not recognized/processed the same, so I moved
> everything on one line to avoid this.

I see.  So basically this tests for more code paths to ignore
backslash commands and it improves the coverage of \elif.  Applied
after fixing two nits:
- Indentation was incorrect.
- Moved the \elif test closer to the existing one for the false
branch (you can grep #2 to find it).
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Create collation reporting the ICU locale display name
Next
From: Alvaro Herrera
Date:
Subject: Re: Do not check unlogged indexes on standby