On Mon, Sep 09, 2019 at 03:35:23PM -0400, Tom Lane wrote:
> I think this probably is committable now, though of course it'd
> be good for somebody to review it (and maybe test on Windows
> before it hits the buildfarm?)
I have looked at the patch and tested it a bit on Windows with MSVC
(TAP, bincheck, etc.), and the logic looks fine. Thanks.
Do we need to worry about the port being opened after the external PID
file is written though? With some imagination it is possible to
imagine that some folks rely on the external PID file to be present
before attempting to access Postgres when not using pg_ctl. Still, I
would discard that as postmaster.pid gets written before opening the
port already.
--
Michael
