Improve error detections in TAP tests by spreading safe_psql - Mailing list pgsql-hackers

From Michael Paquier
Subject Improve error detections in TAP tests by spreading safe_psql
Date
Msg-id 20190828064946.GJ1965@paquier.xyz
Whole thread Raw
Responses Re: Improve error detections in TAP tests by spreading safe_psql  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi all,

This is a follow-up of the discussion which happened here after Tom
has committed fb57f40:
https://www.postgresql.org/message-id/20190828012439.GA1965@paquier.xyz

I have reviewed the TAP tests, and we have much more spots where it
is better to use PostgresNode::safe_psql instead PostgresNode::psql so
as the test dies immediately if there is a failure on a query which
should never fail.

Attached are the spots I have found.  Any thoughts or opinions?
Thanks,
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: "movead.li@highgo.ca"
Date:
Subject: Re: Re: Email to hackers for test coverage
Next
From: Fabien COELHO
Date:
Subject: Re: refactoring - share str2*int64 functions