Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclaredidentifier 'FD_SETSIZE' - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclaredidentifier 'FD_SETSIZE'
Date
Msg-id 20190821140246.GE26424@paquier.xyz
Whole thread Raw
In response to Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclaredidentifier 'FD_SETSIZE'  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclaredidentifier 'FD_SETSIZE'
List pgsql-bugs
On Wed, Aug 21, 2019 at 09:49:54AM -0400, Alvaro Herrera wrote:
> On 2019-Aug-21, Michael Paquier wrote:
>> I quite like the suggestion from Andres to keep the message simple
>> with "too many jobs for this platform's select()".  You are indeed
>> right about the pg_log_fatal() part here, I have changed the patch to
>> do that on my local branch.
>
> Well, it's a user-facing error, so I'd rather make it user-friendly.
> It doesn't seem difficult, or unreliable enough not to try.

Still, in this case, because of the nature of FD_SETSIZE the hint may
finish by being wrong, no?  I am not sure that it is worth going this
way.
--
Michael

Attachment

pgsql-bugs by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclaredidentifier 'FD_SETSIZE'
Next
From: Ashutosh Sharma
Date:
Subject: Re: BUG #15971: Behaviour of SUBSTR function depending on its arguments