Postgres Pro
Downloads
Home   >   mailing lists

Re: some SCRAM read_any_attr() confusion - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: some SCRAM read_any_attr() confusion
Date
Msg-id 20190817125750.GB6079@paquier.xyz
Whole thread Raw
In response to some SCRAM read_any_attr() confusion  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: some SCRAM read_any_attr() confusion  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Tree view 
On Sat, Aug 17, 2019 at 10:11:27AM +0200, Peter Eisentraut wrote:
> I was a bit confused by some of the comments around the SCRAM function
> read_any_attr(), used to skip over extensions.
>
> The comment "Returns NULL if there is attribute.", besides being
> strangely worded, appears to be wrong anyway, because the function never
> returns NULL.

This may have come from an incorrect merge with a past version when
this code has been developed.  +1 for me for your suggestions and your
patch.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: some SCRAM read_any_attr() confusion
Next
From: Michael Paquier
Date:
Subject: Re: default_table_access_method is not in sample config file