Re: some SCRAM read_any_attr() confusion - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: some SCRAM read_any_attr() confusion
Date
Msg-id 1d869d12-0543-f817-e955-b614f9112354@2ndquadrant.com
Whole thread Raw
In response to Re: some SCRAM read_any_attr() confusion  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On 2019-08-17 14:57, Michael Paquier wrote:
> On Sat, Aug 17, 2019 at 10:11:27AM +0200, Peter Eisentraut wrote:
>> I was a bit confused by some of the comments around the SCRAM function
>> read_any_attr(), used to skip over extensions.
>>
>> The comment "Returns NULL if there is attribute.", besides being
>> strangely worded, appears to be wrong anyway, because the function never
>> returns NULL.
> 
> This may have come from an incorrect merge with a past version when
> this code has been developed.  +1 for me for your suggestions and your
> patch.

committed

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Add "password_protocol" connection parameter to libpq
Next
From: Peter Eisentraut
Date:
Subject: Re: ICU for global collation