Re: partition routing layering in nodeModifyTable.c - Mailing list pgsql-hackers

From Andres Freund
Subject Re: partition routing layering in nodeModifyTable.c
Date
Msg-id 20190803173236.dz6uzqat6cscymi4@alap3.anarazel.de
Whole thread Raw
In response to Re: partition routing layering in nodeModifyTable.c  (Etsuro Fujita <etsuro.fujita@gmail.com>)
Responses Re: partition routing layering in nodeModifyTable.c  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

On 2019-08-03 19:41:55 +0900, Etsuro Fujita wrote:
> > I don't like
> > ExecFindResultRelInfo at all. What's the point of it? It's introduction
> > is still an API break - I don't understand why that break is better than
> > just passing the ResultRelInfo directly to BeginDirectModify()?
> 
> What API does that function break?

You need to call it, whereas previously you did not need to call it. The
effort to change an FDW to get one more parameter, or to call that
function is about the same.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions
Next
From: Tom Lane
Date:
Subject: Re: partition routing layering in nodeModifyTable.c