Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Improve stability of TAP test for synchronous replication - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Improve stability of TAP test for synchronous replication
Date
Msg-id 20190724225651.GA6000@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Improve stability of TAP test for synchronous replication  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
List pgsql-committers
Tree view 
On Wed, Jul 24, 2019 at 02:17:14PM -0400, Andrew Dunstan wrote:
> This broke our perl coding rules:
>
> ./src/test/recovery/t/007_sync_rep.pl: Subroutine
> "start_standby_and_wait" does not end with "return" at line 33,
> column 1.  See page 197 of PBP.  (Severity: 5)

Fixed, thanks.  Indeed I can see that pgperlcritic complains here, and
I have added a call in my pre-commit scripts for the future.
--
Michael
Attachment

pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Fix failure with pgperlcritic from the TAP test of synchronousr
Next
From: Andres Freund
Date:
Subject: pgsql: Fix system column accesses in ON CONFLICT ... RETURNING.