Postgres Pro
Downloads
Home   >   mailing lists

Re: Race conditions with TAP test for syncrep - Mailing list pgsql-hackers

From Noah Misch
Subject Re: Race conditions with TAP test for syncrep
Date
Msg-id 20190723064553.GA2008253@rfd.leadboat.com
Whole thread Raw
In response to Re: Race conditions with TAP test for syncrep  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Race conditions with TAP test for syncrep  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
On Tue, Jun 18, 2019 at 09:59:08AM +0900, Michael Paquier wrote:
> On Mon, Jun 17, 2019 at 10:50:39AM -0400, Alvaro Herrera wrote:
> > I think this should be note() rather than print(), or maybe diag().  (I
> > see that we have a couple of other cases which use print() in the tap
> > tests, which I think should be note() as well.)
> 
> OK.  Let's change it for this patch.

PostgresNode uses "print" the same way.  The patch does close the intended
race conditions, and its implementation choices look fine to me.

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: initdb recommendations
Next
From: Ning Yu
Date:
Subject: Re: Possible race condition in pg_mkdir_p()?