Many message seem lost during moving to new environmet..
I'm digging the archive but coudn't find the message for v15..
At Thu, 11 Jul 2019 18:03:35 -0700, Noah Misch <noah@leadboat.com> wrote in
<20190712010335.GB1610889@rfd.leadboat.com>
> On Wed, Jul 10, 2019 at 01:19:14PM +0900, Kyotaro Horiguchi wrote:
> > Hello. Rebased the patch to master(bd56cd75d2).
>
> It looks like you did more than just a rebase, because this v16 no longer
> modifies many files that v14 did modify. (That's probably good, since you had
> pending review comments.) What other changes did you make?
Yeah.. Maybe I forgot to send pre-v15 or v16 before rebasing.
v14: WAL-logging is controled by AMs and syncing at commit is
controled according to the behavior. At-commit sync is still
controlled per-relation basis, which means it must be
processed before transaction state becomes TRNAS_COMMIT. So
it needs to be separated into PreCommit_RelationSync() from
AtEOXact_RelationCache().
v15: The biggest change is that at-commit sync is changed to smgr
basis. At-commit sync is programmed at creation of a storage
file (RelationCreateStorage), and smgrDoPendingDelete(or
smgrDoPendingOperations after rename) runs syncs. AM are no
longer involved and all permanent relations are WAL-skipped at
all in the creation transaction while wal_level=minimal.
All storages created for a relation are once synced then
removed at commit.
v16: rebased.
The v16 seems no longer works so I'll send further rebased version.
Sorry for the late reply and confusion..
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
