On Sat, Jul 6, 2019 at 03:24:25PM -0500, Justin Pryzby wrote:
> On Tue, Apr 30, 2019 at 07:14:04PM -0500, Justin Pryzby wrote:
> > On Tue, Apr 30, 2019 at 09:48:14PM +0300, Alexander Korotkov wrote:
> > > I'd like to add couple of comments from my side.
> >
> > > > - returns an error because the second template string space is consumed
> > > > - by the letter <literal>J</literal> in the input string.
> > > > + returns an error because the second space in the template string consumes
> > > > + the letter <literal>M</literal> from the input string.
> > >
> > > Why <literal>M</literal>? There is no letter "M" is input string.
> > > The issue here is that we already consumed "J" from "JUN" and trying
> > > to match "UN" to "MON". So, I think we should live
> > > <literal>J</literal> here. The rest of this change looks good.
> >
> > Seems like I confused myself while resolving rebase conflict.
> >
> > Thanks for checking.
>
> Find attached updated patch, which seems to still be needed.
>
> This was subsumed and now extracted from a larger patch, from which Michael at
> one point applied a few hunks.
> I have some minor updates based on review from Andres, but there didn't seem to
> be much interest so I haven't pursued it.
> https://www.postgresql.org/message-id/20190520182001.GA25675%40telsasoft.com
Patch applied back through PG 12. Thanks.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
