Re: mcv compiler warning - Mailing list pgsql-hackers

From Tomas Vondra
Subject Re: mcv compiler warning
Date
Msg-id 20190705150612.t3j2mukkbwtk3az7@development
Whole thread Raw
In response to mcv compiler warning  (Jeff Janes <jeff.janes@gmail.com>)
List pgsql-hackers
On Fri, Jul 05, 2019 at 10:13:25AM -0400, Jeff Janes wrote:
>One of the recent mcv commits introduced an unused variable warning.
>
>mcv.c: In function 'statext_mcv_serialize':
>mcv.c:914:7: warning: unused variable 'itemlen' [-Wunused-variable]
>   int   itemlen = ITEM_SIZE(dim);
>
>The attached fixes it.
>

Thanks.

I think I'll just get rid of the variable entirely, and will just call
the macro from the assert directly. The variable used to be referenced
on multiple places, but that changed during the serialization code
reworks.


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services 



pgsql-hackers by date:

Previous
From: Ronan Dunklau
Date:
Subject: Re: Inconsistency between attname of index and attname of relation
Next
From: Euler Taveira
Date:
Subject: Re: Inconsistency between attname of index and attname of relation