Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] get rid of StdRdOptions, use individual binaryreloptions representation for each relation kind instead - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCH] get rid of StdRdOptions, use individual binaryreloptions representation for each relation kind instead
Date
Msg-id 20190701180217.GA15133@alvherre.pgsql
Whole thread Raw
In response to Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead  (Nikolay Shaplov <dhyan@nataraj.su>)
List pgsql-hackers
Tree view 
It seems strange to have relation_reloptions which abstracts away the
need to know which function to call for each relkind, and separately
have a bunch of places that call the specific relkind.  Why not just
call the specific function directly?  It doesn't seem that we're gaining
any abstraction ... maybe it'd be better to just remove
relation_reloptions entirely.  Or maybe we need to make it do a better
job so that other places don't have to call the specific functions at
all.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Surafel Temesgen
Date:
Subject: Change atoi to strtol in same place
Next
From: Alvaro Herrera
Date:
Subject: Re: [PATCH][PROPOSAL] Add enum releation option type