Postgres Pro
Downloads
Home   >   mailing lists

Re: check_recovery_target_lsn() does a PG_CATCH without a throw - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: check_recovery_target_lsn() does a PG_CATCH without a throw
Date
Msg-id 20190630123552.GB2286@paquier.xyz
Whole thread Raw
In response to Re: check_recovery_target_lsn() does a PG_CATCH without a throw  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: check_recovery_target_lsn() does a PG_CATCH without a throw  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
On Sun, Jun 30, 2019 at 11:06:58AM +0200, Peter Eisentraut wrote:
> I ended up rewriting this by extracting the parsing code into
> pg_lsn_in_internal() and having both pg_lsn_in() and
> check_recovery_target_lsn() calling it.  This mirrors similar
> arrangements in float.c

The refactoring looks good to me (including what you have just fixed
with PG_RETURN_LSN).  Thanks for considering it.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: Add parallelism and glibc dependent only options to reindexdb
Next
From: Alexander Lakhin
Date:
Subject: Fix typos and inconsistencies for HEAD