Re: Custom table AMs need to include heapam.h because ofBulkInsertState - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Custom table AMs need to include heapam.h because ofBulkInsertState
Date
Msg-id 20190601195505.GH1905@paquier.xyz
Whole thread Raw
In response to Re: Custom table AMs need to include heapam.h because ofBulkInsertState  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Sat, Jun 01, 2019 at 12:19:43PM -0700, Andres Freund wrote:
> Yea, I think we should do that at some point. But I'm not sure this is
> the right design. Bulk insert probably needs to rather be something
> that's allocated inside the AM.

Yeah, actually you may be right that I am not taking the correct path
here.  At quick glance it looks that there is a strong relationship
between the finish_bulk_insert callback and the bistate free already,
so we could do much better than moving the code around.  Perhaps we
could just have a TODO?  As one of the likely-doable items.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: psql completion bugs with access methods
Next
From: Michael Meskes
Date:
Subject: Re: coverage additions