Dead stores in src/common/sha2.c - Mailing list pgsql-hackers

From Hamlin, Garick L
Subject Dead stores in src/common/sha2.c
Date
Msg-id 20190529132415.GA12011@isc.upenn.edu
Whole thread Raw
Responses Re: Dead stores in src/common/sha2.c  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
I ran clang checker and noticed these.   It looks like the
sha2 implementation is trying to zero out state on exit, but
clang checker finds at least 'a' is a dead store.

Should we fix this?
Is something like the attached sensible?
Is there a common/better approach to zero-out in PG ?

Garick

Attachment

pgsql-hackers by date:

Previous
From: Gilles Darold
Date:
Subject: Doc fix on information_schema.views
Next
From: Michael Paquier
Date:
Subject: Re: Dead stores in src/common/sha2.c