Re: [PATCH v1] Add a way to supply stdin to TAP tests - Mailing list pgsql-hackers

From Kyotaro HORIGUCHI
Subject Re: [PATCH v1] Add a way to supply stdin to TAP tests
Date
Msg-id 20190507.110532.236313028.horiguchi.kyotaro@lab.ntt.co.jp
Whole thread Raw
In response to [PATCH v1] Add a way to supply stdin to TAP tests  (David Fetter <david@fetter.org>)
Responses Re: [PATCH v1] Add a way to supply stdin to TAP tests  (David Fetter <david@fetter.org>)
List pgsql-hackers
Hi.

At Sun, 28 Apr 2019 17:07:16 +0200, David Fetter <david@fetter.org> wrote in <20190428150716.GP28936@fetter.org>
> Our test coverage needs all the help it can get.
> 
> This patch, extracted from another by Fabian Coelho, helps move things
> in that direction.
> 
> I'd like to argue that it's not a new feature, and that it should be
> back-patched as far as possible.

The comment for the parameter "in".

+# - in: standard input

Perhaps this is "string to be fed to standard input". This also
can be a I/O reference but we don't care that?

+    $in = '' if not defined $in;

run($cmd, '<', \undef) seems to work, maybe assuming "<
/dev/null", which might be better?

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center




pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Regression test PANICs with master-standby setup on same machine
Next
From: Tom Lane
Date:
Subject: Re: reindexdb & clusterdb broken against pre-7.3 servers