Re: Heap lock levels for REINDEX INDEX CONCURRENTLY not quite right? - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Heap lock levels for REINDEX INDEX CONCURRENTLY not quite right?
Date
Msg-id 20190503152321.pvmfdqx2togymbje@alap3.anarazel.de
Whole thread Raw
In response to Re: Heap lock levels for REINDEX INDEX CONCURRENTLY not quite right?  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: Heap lock levels for REINDEX INDEX CONCURRENTLY not quite right?  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Hi,

On 2019-05-03 09:37:07 +0200, Peter Eisentraut wrote:
> REINDEX CONCURRENTLY is still deadlock prone because of
> WaitForOlderSnapshots(), so this doesn't actually fix your test case,
> but that seems unrelated to this particular issue.

Right.

I've not tested the change, but it looks reasonable to me. The change
of moving the logic the reset of *heapOid to the unlock perhaps is
debatable, but I think it's OK.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: POC: Cleaning up orphaned files using undo logs
Next
From: Alvaro Herrera
Date:
Subject: error messages in extended statistics