Re: pgsql: Fix memory leak in pgbench - Mailing list pgsql-committers

From Alvaro Herrera
Subject Re: pgsql: Fix memory leak in pgbench
Date
Msg-id 20190411035841.GA14826@alvherre.pgsql
Whole thread Raw
In response to Re: pgsql: Fix memory leak in pgbench  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: pgsql: Fix memory leak in pgbench  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-committers
On 2019-Apr-10, Masahiko Sawada wrote:

> This change leads a compiler warning on my machine:
> 
> pgbench.c: In function ‘readCommandResponse’:
> pgbench.c:2730: warning: ISO C90 forbids mixed declarations and code

> I think we should declare is_last before doing next_res = PQgetResult(st->con).
> 
> Attached patch fixes it.

Thanks, pushed.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Fix declaration after statement
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Fix memory leak in pgbench