Re: Misleading errors with column references in default expressionsand partition bounds - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Misleading errors with column references in default expressionsand partition bounds
Date
Msg-id 20190328121411.GA2558@paquier.xyz
Whole thread Raw
In response to Misleading errors with column references in default expressions andpartition bounds  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Misleading errors with column references in default expressionsand partition bounds
List pgsql-hackers
On Wed, Mar 27, 2019 at 12:13:16PM +0900, Michael Paquier wrote:
> ParseExprKind is an enum, so listing all the options without the
> default has the advantage to generate a warning if somebody adds a
> value.  This way anybody changing this code will need to think about
> it.

A bit late, but committed without the case/default.

>>        ... The value
>>        is any variable-free expression (in particular, cross-references
>>        to other columns in the current table are not allowed).  Subqueries
>>        are not allowed either.
>
> Okay, I think I see your point here.  That sounds sensible.

And I have used this suggestion from Tom as well for the docs.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Enable data checksums by default
Next
From: Adrien NAYRAT
Date:
Subject: Re: Log a sample of transactions