Re: Enable data checksums by default - Mailing list pgsql-hackers

From Christoph Berg
Subject Re: Enable data checksums by default
Date
Msg-id 20190328083816.GA31223@msg.df7cb.de
Whole thread Raw
In response to Re: Enable data checksums by default  (Ants Aasma <ants.aasma@eesti.ee>)
Responses Re: Enable data checksums by default
List pgsql-hackers
Re: Ants Aasma 2019-03-27 <CA+CSw_twXdRzDN2XsSZBxEj63DeZ+f6_hs3Qf7hmXfenxSq+jg@mail.gmail.com>
> Can you try with postgres compiled with CFLAGS="-O2 -march=native"? There's
> a bit of low hanging fruit there to use a runtime CPU check to pick a
> better optimized checksum function.

Frankly, no. This is with the apt.pg.o packages which are supposed to
be usable by everyone. If there is a better per-CPU checksum function,
PG should pick it at runtime. Special compiler flags are a no-go here.

CPPFLAGS = -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -I/usr/include/libxml2 -I/usr/include/mit-krb5
CFLAGS = -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels
-Wmissing-format-attribute-Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard
-Wno-format-truncation-Wno-stringop-truncation -g -g -O2 -fstack-protector-strong -Wformat -Werror=format-security
-fno-omit-frame-pointer

Christoph



pgsql-hackers by date:

Previous
From: "Nagaura, Ryohei"
Date:
Subject: RE: Timeout parameters
Next
From: Fabien COELHO
Date:
Subject: Re: Progress reporting for pg_verify_checksums