Re: renaming ExecStoreWhateverTuple - Mailing list pgsql-hackers

From Andres Freund
Subject Re: renaming ExecStoreWhateverTuple
Date
Msg-id 20190325163656.d3jcw45gg4sk7ypn@alap3.anarazel.de
Whole thread Raw
In response to Re: renaming ExecStoreWhateverTuple  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: renaming ExecStoreWhateverTuple
List pgsql-hackers
Hi,

On 2019-03-25 12:33:38 -0400, Tom Lane wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
> > Maybe we don't really need the word "tuple".  Like we could just make
> > it slot_store_heap() or SlotStoreHeap().  A slot can only store a
> > tuple, after all.
> 
> I don't think it's wise to think of these things as just "slots";
> that name is way too generic.  They are "tuple slots", and so that
> word has to stay in the relevant function names.

Hm. But we already have slot_{getsomeattrs, getallattrs, attisnull,
getattr, getsysattr}. But perhaps the att in there is enough addiitional
information?

Although now I'm looking at consistency annoyed at slot_attisnull (no r)
and slot_getattr (r) ;)

Greetings,

Andres Freund


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: renaming ExecStoreWhateverTuple
Next
From: Tom Lane
Date:
Subject: Re: renaming ExecStoreWhateverTuple