On Fri, Mar 22, 2019 at 02:23:17PM +0100, Michael Banck wrote:
> The current version prints a newline when it progress reporting is
> toggled off. Do you mean there is a hazard that this happens right when
> we are printing the progress, so end up with a partly garbage line? I
> don't think that'd be so bad to warrant further code complexitiy, after
> all, the user explicitly wanted the progress to stop.
>
> But maybe I am misunderstanding?
The latest patch does not apply because of mainly ed308d7. Could you
send a rebase?
FWIW, I would remove the signal toggling stuff from the patch and keep
the logic simple at this stage. Not having a solution which works on
Windows is perhaps not a strong reason to not include it, but it's a
sign that we could perhaps design something better, and that's
annoying. Personally I think that I would just use --progress all the
time and not use the signaling part at all, my 2c.
--
Michael
