On Fri, Mar 22, 2019 at 02:59:31PM +0100, Fabien COELHO wrote:
> On write(), the error message is not translatable whereas it is for all
> others.
Fixed.
> I agree that a BIG STRONG warning is needed about not to start the cluster
> under pain of possible data corruption. I still think that preventing this
> is desirable, preferably before v12.
For now the docs mention that in a paragraph as Michael Banck has
suggested. Not sure that this deserves a warning portion.
> Otherwise, my remaining non showstopper (committer's opinion matters more)
> issues:
>
> Doc: A postgres cluster is like an Oracle instance. I'd use "replicated
> setup" instead of "cluster", and "cluster" instead of "instance. I'll try to
> improve the text, possibly over the week-end.
Right. I have reworded that using your suggestions.
And committed the main part. I'll look after the --no-sync part in a
bit.
--
Michael