Re: Removal of duplicate variable declarations in fe-connect.c - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Removal of duplicate variable declarations in fe-connect.c
Date
Msg-id 20190222042246.GA24416@paquier.xyz
Whole thread Raw
In response to Removal of duplicate variable declarations in fe-connect.c  (Haribabu Kommi <kommi.haribabu@gmail.com>)
Responses Re: Removal of duplicate variable declarations in fe-connect.c  (Haribabu Kommi <kommi.haribabu@gmail.com>)
List pgsql-hackers
On Fri, Feb 22, 2019 at 11:33:17AM +1100, Haribabu Kommi wrote:
> During the development of another feature, I found that same local
> variables are declared twice.
> IMO, there is no need of again declaring the local variables. Patch
> attached.

Indeed, fixed.  That's not a good practice, and each variable is
assigned in its own block before getting used, so there is no
overlap.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Unified security key managment
Next
From: Michael Paquier
Date:
Subject: Re: Using old master as new replica after clean switchover