Postgres Pro
Downloads
Home   >   mailing lists

Re: [Suspect SPAM] Better error messages when lacking connectionslots for autovacuum workers and bgworkers - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [Suspect SPAM] Better error messages when lacking connectionslots for autovacuum workers and bgworkers
Date
Msg-id 20190214230854.GB2240@paquier.xyz
Whole thread Raw
In response to Re: [Suspect SPAM] Better error messages when lacking connectionslots for autovacuum workers and bgworkers  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
List pgsql-hackers
Tree view 
On Thu, Feb 14, 2019 at 09:04:37PM +0900, Kyotaro HORIGUCHI wrote:
> I agree to the distinctive messages, but the autovaccum and
> bgworker cases are in a kind of internal error, and they are not
> "connection"s. I feel that elog is more suitable for them.

I used ereport() for consistency with the existing code, still you are
right that we ought to use elog() as this is the case of a problem
which should not happen.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH] xlogreader: do not read a file block twice
Next
From: Michael Paquier
Date:
Subject: Re: pg_basebackup ignores the existing data directory permissions