Re: pgsql: Fix included file path for modern perl - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Fix included file path for modern perl
Date
Msg-id 20190206092715.7mpswmfx2znvu6bq@alap3.anarazel.de
Whole thread Raw
In response to pgsql: Fix included file path for modern perl  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pgsql: Fix included file path for modern perl  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-committers
Hi,

On 2019-02-06 00:36:07 +0000, Andrew Dunstan wrote:
> Fix included file path for modern perl
> 
> Contrary to the comment on 772d4b76, only paths starting with "./" or
> "../" are considered relative to the current working directory by perl's
> "do" function. So this patch converts all the relevant cases to use "./"
> paths. This only affects MSVC.
> 
> Backpatch to all live branches.

Hm, is it possible this broke
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=whelk&dt=2019-02-06%2002%3A41%3A15
and
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=dory&dt=2019-02-06%2000%3A45%3A25
both report something like
Use of uninitialized value in multiplication (*) at src/tools/msvc/Solution.pm line 181, <$i> line 783.
Use of uninitialized value in division (/) at src/tools/msvc/Solution.pm line 184, <$i> line 783.
Illegal division by zero at src/tools/msvc/Solution.pm line 184, <$i> line 783.

starting with this commit.

Greetings,

Andres Freund


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Fix heap_getattr() handling of fast defaults.
Next
From: Andrew Dunstan
Date:
Subject: Re: pgsql: Fix included file path for modern perl