Re: Don't wake up to check trigger file if none is configured - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Don't wake up to check trigger file if none is configured
Date
Msg-id 20190131070956.GE13429@paquier.xyz
Whole thread Raw
In response to Re: Don't wake up to check trigger file if none is configured  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Don't wake up to check trigger file if none is configured  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Wed, Dec 26, 2018 at 03:24:01PM +0900, Michael Paquier wrote:
> It seems to me that the comment on top of WaitLatch should be clearer
> about that, and that the current state leads to confusion.  Another
> thing coming to my mind is that I think it would be useful to make the
> timeout configurable so as instances can react more quickly in the
> case of a sudden death of the WAL receiver (or to check faster for a
> trigger file if the HA application is to lazy to send a signal to the
> standby host).
>
> Attached is a patch to improve the comment for now.

So, does somebody have an objection if I apply the comment patch?  Per
the reasons above, the proposed patch is not correct, but the code can
be more descriptive.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Cache lookup errors with functions manipulation object addresses
Next
From: "Matsumura, Ryo"
Date:
Subject: RE: [PROPOSAL]a new data type 'bytea' for ECPG