Re: BUG #15578: Executing json_populate_recordset with an emptyarray causes a segmentation fault - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: BUG #15578: Executing json_populate_recordset with an emptyarray causes a segmentation fault
Date
Msg-id 20190107045918.GC22498@paquier.xyz
Whole thread Raw
In response to BUG #15578: Executing json_populate_recordset with an empty arraycauses a segmentation fault  (PG Bug reporting form <noreply@postgresql.org>)
List pgsql-bugs
On Mon, Jan 07, 2019 at 03:52:26AM +0000, PG Bug reporting form wrote:
> When executing json_populate_recordset/jsonb_populate_recordset with an
> empty array, a segmentation fault occurs and the server process is
> terminated. The issue occurs regardless of the type used. In previous
> versions this would return null.

This has been already fixed by a recent commit, which will be released
with 11.2 in the next round of minor releases (see also 595220a which
applies to REL_11_STABLE):
commit: eba2ce17121f198316d050e71d8bd049a43783ba
author: Tom Lane <tgl@sss.pgh.pa.us>
date: Thu, 22 Nov 2018 15:14:01 -0500
committer: Tom Lane <tgl@sss.pgh.pa.us>
date: Thu, 22 Nov 2018 15:14:01 -0500
Fix another crash in json{b}_populate_recordset and
json{b}_to_recordset.

populate_recordset_worker() failed to consider the possibility that the
supplied JSON data contains no rows, so that update_cached_tupdesc never
got called.  This led to a null-pointer dereference since commit 9a5e8ed28;
before that it led to a bogus "set-valued function called in context
that cannot accept a set" error.  Fix by forcing the update to happen.

Per bug #15514.  Back-patch to v11 as 9a5e8ed28 was.  (If we were excited
about the bogus error, we could perhaps go back further, but it'd take more
work to figure out how to fix it in older branches.  Given the lack of
field complaints about that aspect, I'm not excited.)

Discussion: https://postgr.es/m/15514-59d5b4c4065b178b@postgresql.org
--
Michael

Attachment

pgsql-bugs by date:

Previous
From: PG Bug reporting form
Date:
Subject: BUG #15578: Executing json_populate_recordset with an empty arraycauses a segmentation fault
Next
From: Tom Lane
Date:
Subject: Re: BUG #15578: Executing json_populate_recordset with an empty array causes a segmentation fault