On 2018-Nov-06, LAM JUN RONG wrote:
> Hi,
>
> I must have forgotten to change the diff.
I noticed that you edited the diff by hand -- the line count in the last
hunk doesn't match. This causes both "path" and "git apply" to reject
the patch saying it's corrupted. I suggest not to do that. I can get
it to apply by changing the "+239,14" in the previous-to-last hunk
header to "+239,13" IIRC. (I think there's a utility to recompute line
counts in hunk headers, "rediff" I think, but better not to edit the
patch manually in the first place.)
Besides that, I have a hard time considering this patch committable.
There are some good additions, but they are mixed with some wording
changes that seem to be there just because the author doesn't like the
original, not because they're actual improvements.
One thing I definitely didn't like is that lines go well over 80 chars
per line. We aren't terribly strict about that when there are long XML
tags, but this patch is over the top in that department.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
