Postgres Pro
Downloads
Home   >   mailing lists

Re: Change pgarch_readyXlog() to return .history files first - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Change pgarch_readyXlog() to return .history files first
Date
Msg-id 20181221235514.GH1948@paquier.xyz
Whole thread Raw
In response to Re: Change pgarch_readyXlog() to return .history files first  (David Steele <david@pgmasters.net>)
Responses Re: Change pgarch_readyXlog() to return .history files first  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
On Fri, Dec 21, 2018 at 08:17:12AM +0200, David Steele wrote:
> I thought about doing that, but wanted to focus on the task at hand.  It
> does save a strcpy and a bit of stack space, so seems like a win.
>
> Overall, the patch looks good to me.  I think breaking up the if does make
> the code more readable.

Thanks for the lookups.  I can see that the patch applies without
conflicts down to 9.4, and based on the opinions gathered on this
thread back-patching this stuff is the consensus, based on input from
Kyotaro Horiguchi and David Steele (I don't mind much myself).  So,
any objections from others in doing so?
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH] Improve tab completion for CREATE TABLE
Next
From: Alexander Korotkov
Date:
Subject: Re: pgsql: Check for conflicting queries during replay of gistvacuumpage()