Re: Too-short timeouts in test code - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Too-short timeouts in test code
Date
Msg-id 20181209032654.GE1833@paquier.xyz
Whole thread Raw
In response to Re: Too-short timeouts in test code  (Noah Misch <noah@leadboat.com>)
List pgsql-hackers
On Sat, Dec 08, 2018 at 06:24:35PM -0800, Noah Misch wrote:
> pg_recvlogical_upto() has the ability to make timeout non-fatal, by calling it
> in an array context.  No in-tree test uses that.  Out-of-tree code using that
> feature would likely benefit from the ability to set timeout duration.  Hence,
> I'm inclined not remove the timeout duration parameter.

No objections with this line of thoughts.  The rest of the patch looks
fine to me.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: Too-short timeouts in test code
Next
From: Michael Paquier
Date:
Subject: Re: [Todo item] Add entry creation timestamp column topg_stat_replication