Postgres Pro
Downloads
Home   >   mailing lists

Re: Use durable_unlink for .ready and .done files for WAL segmentremoval - Mailing list pgsql-hackers

From Kyotaro HORIGUCHI
Subject Re: Use durable_unlink for .ready and .done files for WAL segmentremoval
Date
Msg-id 20181206.135546.16142622.horiguchi.kyotaro@lab.ntt.co.jp
Whole thread Raw
In response to Re: Use durable_unlink for .ready and .done files for WAL segmentremoval  ("Bossart, Nathan" <bossartn@amazon.com>)
Responses Re: Use durable_unlink for .ready and .done files for WAL segmentremoval
List pgsql-hackers
Tree view 
Hello.

At Wed, 5 Dec 2018 16:11:23 +0000, "Bossart, Nathan" <bossartn@amazon.com> wrote in
<DB47EBD7-7291-4C39-9F8F-BE42E5193BD5@amazon.com>
> The v4 patch looks good to me!

durable_unlnk has two modes of faiure. Failure to unlink and
fsync. If once it fails at the fsync stage, subsequent
durable_unlink calls for the same file always fail to unlink with
ENOENT.  If durable_unlink is intended to be called repeatedly on
falure, perhaps it should return a different code for each
failure so that the caller can indentify what to do next.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: error message when subscription target is a partitioned table
Next
From: "Nagaura, Ryohei"
Date:
Subject: RE: Timeout parameters