Re: [RFC] Removing "magic" oids - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [RFC] Removing "magic" oids
Date
Msg-id 20181121000759.dgcbhr2nizkcfjhk@alap3.anarazel.de
Whole thread Raw
In response to Re: [RFC] Removing "magic" oids  (Andres Freund <andres@anarazel.de>)
Responses Re: [RFC] Removing "magic" oids  (Thomas Munro <thomas.munro@enterprisedb.com>)
Re: [RFC] Removing "magic" oids  (Andreas Karlsson <andreas@proxel.se>)
Re: [RFC] Removing "magic" oids  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
List pgsql-hackers
Hi,

On 2018-11-20 01:52:27 -0800, Andres Freund wrote:
> I'm pretty happy with the new state. Unless somebody announces they want
> to do a review soon-ish, I'm planning to commit this soon. It's a
> painful set to keep up2date, and it's blocking a few other patches.  I'm
> sure we'll find some things to adapt around the margins, but imo the
> patch as a whole looks pretty reasonable.
> 
> Missing:
> - nice and long commit message
> - another detailed line-by-line read of the patch (last round took like
>   3h :()
> 
> 341 files changed, 2263 insertions(+), 4249 deletions(-)

I've now pushed this. There's one bugfix (forgot to unset replaces for
the oid column in heap_modify_tuple), and one mostly cosmetic change:
Previously the .bki insert lines had the oid duplicated between OID =
and the normal column, now it's just the latter.

Let's see what I broke :/

Regards,

Andres


pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: CF app feature request
Next
From: Michael Paquier
Date:
Subject: Re: Add extension options to control TAP and isolation tests