Re: Wrong aggregate result when sorting by a NULL value - Mailing list pgsql-bugs

From Andres Freund
Subject Re: Wrong aggregate result when sorting by a NULL value
Date
Msg-id 20181103215009.slavgzc2kvyhpxlf@alap3.anarazel.de
Whole thread Raw
In response to Re: Wrong aggregate result when sorting by a NULL value  (Andres Freund <andres@anarazel.de>)
Responses Re: Wrong aggregate result when sorting by a NULL value
List pgsql-bugs
Hi,

On 2018-11-02 22:57:00 -0700, Andres Freund wrote:
> On 2018-11-02 17:34:43 +0000, Andrew Gierth wrote:
> > >>>>> "Andres" == Andres Freund <andres@anarazel.de> writes:
> > 
> >  >> Andres, do you have time to look at this right now?
> > 
> >  Andres> Thanks for bisecting.  I'll take a look later today.
> > 
> > Looks like this:
> > 
> > +           scratch.d.agg_strict_input_check.nargs = numInputs;
> > 
> > should have been pertrans->numTransInputs instead?
> 
> That looks like it's precisely the reason. I'll push something tomorrow
> PST morning, crediting both you (diagnosis) and Tom (bisecting)
> obviously, unless you prefer to do so yourself.
> 
> It's a bit sad that we don't have any tests that test this :/. I'll add
> something for the specific case, but that'll obviously not be
> exhaustive.

And pushed. Thanks Ondřej for the report, thanks Tom & Andrew for
identifying the issue.

Greetings,

Andres Freund


pgsql-bugs by date:

Previous
From: pinker
Date:
Subject: Re: BUG #15231: After Upgrade from 9.3.23 to 9.6.9 getting ERROR:found xmin 598 from before relfrozenxid 68569164
Next
From: Tom Lane
Date:
Subject: Re: Wrong aggregate result when sorting by a NULL value