Re: Function to promote standby servers - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Function to promote standby servers
Date
Msg-id 20181026045124.GC3909@paquier.xyz
Whole thread Raw
In response to Re: Function to promote standby servers  (Ian Barwick <ian@2ndquadrant.com>)
Responses Re: Function to promote standby servers  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Fri, Oct 26, 2018 at 11:36:00AM +0900, Ian Barwick wrote:
> Documentation for this [*] says "Returns true if promotion is
> successful and false otherwise", which is not correct if "wait" is
> false, as it will always return TRUE.

Yes, in the case where the promotion has been initiated.

> +        <literal>false</literal> otherwise. If <parameter>wait</parameter>
> +        is set to <literal>false</literal>, the function returns <literal>true</literal>
> +        immediately after sending the promotion signal to the postmaster.

Or we could use "the function returns true immediately after initiating
the promotion by sending the promotion signal to the postmaster"?  As a
native speaker which one feels more natural to you?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: PostgreSQL vs SQL/XML Standards
Next
From: Michael Paquier
Date:
Subject: Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER