Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER
Date
Msg-id 20181025235600.GA3909@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, Oct 25, 2018 at 12:52:01PM +0100, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> To keep the code simple, you could do something like that, by checking
>> the head keywords for a match with CREATE TRIGGER, and then move all the
>> existing conditions within it:
>> ...
>>     char *execute_keyword;
>> ...
>>         blah and use execute_keyword in the lists;
>
> Don't think that works unless we remove some of the "const" annotation
> in COMPLETE_WITH; which I'd rather not.

Indeed, gcc just complained about the thing not being a constant after
testing, so please let me discard this suggestion.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Haribabu Kommi
Date:
Subject: Re: PostgreSQL Limits and lack of documentation about them.
Next
From: Michael Paquier
Date:
Subject: Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER