Re: removing unnecessary get_att*() lsyscache functions - Mailing list pgsql-hackers

Hi,

On 2018-10-23 09:11:17 +0900, Michael Paquier wrote:
> On Mon, Oct 22, 2018 at 07:12:28PM +0200, Peter Eisentraut wrote:
> > OK, slightly reworked version attached.
> 
> +   attTup = (Form_pg_attribute) GETSTRUCT(tuple);
>     attnum = ((Form_pg_attribute) GETSTRUCT(tuple))->attnum;
> 
> No need to call twice GETSTRUCT here..  The rest looks fine.

Just about every optimize compiler can optimize that away, it's just a
bit of pointer magic.  Obviously we don't want to repeat longer lines
superfluously, but twice isn't that bad...

Greetings,

Andres Freund