Re: pageinspect: add tuple_data_record() - Mailing list pgsql-hackers

From Andres Freund
Subject Re: pageinspect: add tuple_data_record()
Date
Msg-id 20181017170536.nedsjesikwpv4bki@alap3.anarazel.de
Whole thread Raw
In response to Re: pageinspect: add tuple_data_record()  (James Coleman <jtc331@gmail.com>)
Responses Re: pageinspect: add tuple_data_record()  (James Coleman <jtc331@gmail.com>)
List pgsql-hackers
Hi,

On 2018-10-17 13:04:33 -0400, James Coleman wrote:
> Indeed. But I do think your approach - which means that the binary data is
> > actually interpreded as a datum of a specific type, drastically
> > increases the risk.
> >
> >
> Agreed.
> 
> As I noted earlier, I don't at all think deTOASTing is a must for this
> function to be
> valuable, just as tuple_data_split() is also valuable without deTOASTINGing.
> 
> I believe "best effort" is very reasonable in the case of a what is an
> investigatory
> method to begin with.

It's far from only toast that could be problematic here.

Greetings,

Andres Freund


pgsql-hackers by date:

Previous
From: James Coleman
Date:
Subject: Re: pageinspect: add tuple_data_record()
Next
From: James Coleman
Date:
Subject: Re: pageinspect: add tuple_data_record()